This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Tweak assert -DNDEBUG for the new-Wunused-but-set-{variable,parameter} warnings

From: Roland McGrath <roland at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: Ulrich Drepper <drepper at redhat dot com>, Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Thu, 8 Apr 2010 10:54:06 -0700 (PDT)
Subject: Re: [PATCH] Tweak assert -DNDEBUG for the new-Wunused-but-set-{variable,parameter} warnings
References: <20100408102141.GO3601@sunsite.ms.mff.cuni.cz>

Unfortunately I think this is wrongly incompatible, as Andreas said.
e.g., consider:

#ifndef NDEBUG
static int checker () { ... }
#endif

...
	assert (checker () == 0);
...

Or even worse, it could be hairy macros so that under NDEBUG
the expression is actually unparseable.


Thanks,
Roland

References:
- [PATCH] Tweak assert -DNDEBUG for the new-Wunused-but-set-{variable,parameter} warnings
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]