This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix strstr/strcasestr/fma/fmaf on x86_64

From: Andreas Schwab <schwab at linux-m68k dot org>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: Ulrich Drepper <drepper at redhat dot com>, Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Wed, 02 Sep 2009 12:08:31 +0200
Subject: Re: [PATCH] Fix strstr/strcasestr/fma/fmaf on x86_64
References: <20090902085848.GC3611@sunsite.ms.mff.cuni.cz>

Jakub Jelinek <jakub@redhat.com> writes:

> --- libc/sysdeps/x86_64/multiarch/strstr-c.c.jj	2009-07-23 08:59:29.000000000 +0200
> +++ libc/sysdeps/x86_64/multiarch/strstr-c.c	2009-09-02 10:34:48.000000000 +0200
> @@ -7,6 +7,7 @@
>  
>  #include "string/strstr.c"
>  
> -extern char *__strstr_sse42 (const char *, const char *);
> +extern char *__strstr_sse42 (const char *, const char *) attribute_hidden;
> +extern __typeof (__strstr_sse2) __strstr_sse2 attribute_hidden;

Shouldn't those use the libc_hidden* macros?

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

References:
- [PATCH] Fix strstr/strcasestr/fma/fmaf on x86_64
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]