This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix signal.h

From: Jakub Jelinek <jakub at redhat dot com>
To: Ulrich Drepper <drepper at redhat dot com>
Cc: Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Sat, 20 Nov 2004 19:31:59 +0100
Subject: Re: [PATCH] Fix signal.h
References: <20041120170623.GH23824@sunsite.ms.mff.cuni.cz>
Reply-to: Jakub Jelinek <jakub at redhat dot com>

On Sat, Nov 20, 2004 at 06:06:23PM +0100, Jakub Jelinek wrote:
> I believe the nonnull attributes for __sighandler_t arguments are wrong.
> SIG_DFL (which is ((__sighandler_t) 0) == NULL) is a valid argument
> for these functions.

BTW, is the nonnull attribute for first sigwait/sigwaitinfo/sigtimedwait
correct?  I think so from reading the standards, but in that case I wonder
why we test it, e.g.:
static int
do_sigwaitinfo (const sigset_t *set, siginfo_t *info)
{
#ifdef SIGCANCEL
  sigset_t tmpset;
  if (set != NULL
...

	Jakub

Follow-Ups:
- Re: [PATCH] Fix signal.h
  - From: Ulrich Drepper

References:
- [PATCH] Fix signal.h
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]