This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Fix s390{,x} build


Hi!

The recent dl-tls.c -> dl-sym.c reshuffling broke s390*.
Here is a fix, verified so far with doing dlsym on a STT_TLS symbol
in a shared library.

2004-03-11  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/s390/dl-tls.h: Only add __tls_get_offset assembly if
	IS_IN_rtld.
	(__TLS_GET_ADDR): Use __tls_get_offset, not __tls_get_addr.

--- libc/sysdeps/s390/dl-tls.h.jj	2003-01-28 11:34:02.000000000 +0100
+++ libc/sysdeps/s390/dl-tls.h	2004-03-11 09:47:56.536933703 +0100
@@ -1,5 +1,5 @@
 /* Thread-local storage handling in the ELF dynamic linker.  s390 version.
-   Copyright (C) 2003 Free Software Foundation, Inc.
+   Copyright (C) 2003, 2004 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -31,6 +31,7 @@ typedef struct
 extern void *__tls_get_addr (tls_index *ti) attribute_hidden;
 extern unsigned long __tls_get_offset (unsigned long got_offset);
 
+# ifdef IS_IN_rtld
 /* The special thing about the s390 TLS ABI is that we do not have the
    standard __tls_get_addr function but the __tls_get_offset function
    which differs in two important aspects:
@@ -39,7 +40,7 @@ extern unsigned long __tls_get_offset (u
    2) __tls_get_offset returns the offset of the requested variable to
       the thread descriptor instead of a pointer to the variable.
  */
-#if defined __s390x__
+#  if defined __s390x__
 asm("\n\
 	.text\n\
 	.globl __tls_get_offset\n\
@@ -49,7 +50,7 @@ __tls_get_offset:\n\
 	la	%r2,0(%r2,%r12)\n\
 	jg	__tls_get_addr\n\
 ");
-#elif defined __s390__
+#  elif defined __s390__
 asm("\n\
 	.text\n\
 	.globl __tls_get_offset\n\
@@ -62,12 +63,15 @@ __tls_get_offset:\n\
 	b	0(%r4,%r3)\n\
 1:	.long	__tls_get_addr - 0b\n\
 ");
-#endif
+#  endif
+# endif
 
-#define GET_ADDR_OFFSET \
+# define GET_ADDR_OFFSET \
   (ti->ti_offset - (unsigned long) __builtin_thread_pointer ())
 
-#define __TLS_GET_ADDR(__ti) \
-  (__tls_get_addr(__ti) + (unsigned long) __builtin_thread_pointer ())
+# define __TLS_GET_ADDR(__ti) \
+  ({ extern char _GLOBAL_OFFSET_TABLE_[] attribute_hidden;		  \
+     (void *) __tls_get_offset ((char *) (__ti) - _GLOBAL_OFFSET_TABLE_)  \
+     + (unsigned long) __builtin_thread_pointer (); }) 
 
 #endif

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]