This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PPC64 dl-machine.c change to use GLRO


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Steve Munroe wrote:
>
> -  INTUSE (_dl_signal_error) (0, map->l_name, NULL, buffer);
> +  GLRO(dl_signal_error) (0, map->l_name, NULL, buffer);
>  }

Not correct.  You need to use GLRO for that function only outside ld.so.
 I've checked in a patch.

Oh, and you again haven't updated the copyright year.  In case you use
emacs, use upd-copyr.el (and whitespace.el, I've removed a lot of excess
whitespaces in the ppc files in the last days).  If you use something
else which has macro capabilities try to get something like upd-copyr.el
implemented.  It checks for accurate copyright years before saving.

- -- 
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQFATL3R2ijCOnn/RHQRAs12AJ0QiLVcTHvEYP7zdSP7fN2YgF8jgACggpRe
nVOLHCxxFwk2WzcsNkp3sbU=
=Uufu
-----END PGP SIGNATURE-----


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]