This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: glob must not call globfree


Thorsten Kukuk <kukuk@suse.de> writes:

> I think the problem is our globfree: If called, it only checks if
> gl_pathv is not NULL. I think it should also check, that gl_pathc
> is not zero and set it to zero after freeing gl_pathv. This fixes
> all of our current problems with this.

gl_pathc != 0 for a globfree call is a requirement on the user.  The
implementation shouldn't check it.

If anything has to be changed (I'm still not 100% sure but am willing
to concede it) the glob() function must make sure that gl_pathc is set
to zero if it called globfree().  I've checked in a patch for that.
Give it a try with your tests and please consider adding the tests to
the test suite.

-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]