This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Add more noreturn attributes


On Sat, Apr 21, 2001 at 10:16:28PM +0200, Andreas Jaeger wrote:
> --- linuxthreads/sysdeps/pthread/timer_routines.c	2001/04/21 18:50:28	1.13
> +++ linuxthreads/sysdeps/pthread/timer_routines.c	2001/04/21 20:15:48
> @@ -440,7 +440,6 @@
>      }
>    /* These statements will never be executed since the while loop
>       loops forever - but we have to add them for proper nesting.  */

Just nitpicking then, perhaps the comment should be

    /* This macro will never be executed since the while loop loops
       forever - but we have to add it for proper nesting.  */

? There is just one thing there, not several and I'm not sure whether
pthread_cleanup_pop should be called a statement, it is a statement and
closing brace.

> -  pthread_mutex_unlock (&__timer_mutex);
>    pthread_cleanup_pop (1);

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]