This is the mail archive of the libc-hacker@sourceware.cygnus.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] obstack_printf fix (fixes localedef)


On Tue, Jun 27, 2000 at 09:09:38AM -0700, Ulrich Drepper wrote:
> Jakub Jelinek <jakub@redhat.com> writes:
> 
> > 2000-06-27  Jakub Jelinek  <jakub@redhat.com>
> > 
> > 	* libio/obprintf.c (_IO_obstack_vprintf): Call obstack_make_room,
> > 	not obstack_blank.
> 
> That's really one of those "how could it ever work" errors.  And more
> strange: how could the test in stdio-common/tst-obprintf.c not fail?

I guess for two reasons: obstack_printf is not used too often in real world
applications and if it is used, it was never called with
object_base == next_free == chunk_limit.

BTW: rpm is still failing with the new en_US LC_CTYPE, it causes some rpm
macros not to be expanded, I hope to nail it down soon (went over a gcc
miscompilation of sparc32 glibc in the mean time).

	Jakub

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]