This is the mail archive of the libc-hacker@sourceware.cygnus.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: argh!


I have restored the fstat.  Though I'm absolutely not pleased with
this since the problem this patch solves but ultimately be solved
differently.

Anyhow, I haven't used Zack's complex patch which checks for effective
O_DIRECTORY etc since it could introduce extra problems (who knows
whether the implementation of open on all filesystems on a system is
the same wrt opening file ending with a slash) and the saved time of
fstat call is wasted in many ifs and larger code.


I think that during the glibc 2.2 development we will have to come up
with a scheme which allows to eliminate effectively dead code.  E.g.,
I'll certainly not run a 2.0 kernel anymore and therefore all
compatibility code should be avoided.  Maybe somebody can already
start thinking about this :-)

-- 
---------------.      drepper at gnu.org  ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Cygnus Solutions `--' drepper at cygnus.com   `------------------------


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]