This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 3/7] ldbl-128ibm-compat: Add tests for IBM long double functions
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Paul E Murphy <murphyp at linux dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Fri, 14 Feb 2020 21:13:41 +0000
- Subject: Re: [PATCH 3/7] ldbl-128ibm-compat: Add tests for IBM long double functions
- Ironport-sdr: 9odits/GMnbm5QOx7yShRAeFi4n3YhxxoEsHETAX4UAUUDKiP6DCv0UteXVxtiGAnoKBqo9QSV 1iZoLbeNahc5MRy9tKjv3rsu5C6YEtlEwIcRxqOZdSKpHjQcanJj/DdfoAwgRfrZEp1XvG1PKu P5Cqh/PcMEXDdUV3dfuOQ1wqQoOhxQE7FVJKVCtw/8OZADpvVqVaweAYHZz3uDcDXTWauyQDXl hCzKxbGuPnyLqBLZiyU5s23bm/CtxBpnWlg5LqAI9mTylEJL0Rr7c+UvUWcwnedyBFCcezsbem NaE=
- Ironport-sdr: D7c0oInTd4Rqv1KrWQMLDD0aZjztzVpSy/qcI8RJZ87vwgkA9LRIUDmc+Sp1UW10OcLgekPwIA hsUf9LQqrRZy1oxAPqiMTJ4eCEByM4ZeKcq6ApkbJPDxLmNIcOrqNFw3zvNKSFcunycLNuDsgI J99Lb6BvdDHpIGN052d3O5UjxVbyVB5NXh5TlPF216vTCB/sh9xlXSPl19jK6MFVQgQlIVdBSD 4Uz9jUR35F7ObaO8QGA82TwR3vtaVxwfcZl2J/TkKC+V/k48UkbAIELUvcBKqfdhgFL9LMveJZ Qio=
- References: <20200214161051.32579-1-murphyp@linux.vnet.ibm.com> <20200214161051.32579-4-murphyp@linux.vnet.ibm.com> <alpine.DEB.2.21.2002141728520.15736@digraph.polyomino.org.uk> <11f0956f-a55e-7422-06e0-b0e7ec13d230@linux.ibm.com>
On Fri, 14 Feb 2020, Paul E Murphy wrote:
> The macro might better read as something like
> __LDOUBLE_REDIRECTS_TO_FLOAT128_ABI. Would such be a more fitting name?
Yes, that seems like a better name, as far as I understand how the macro
is used. In any case, it needs a comment to specify its semantics. The
comment needs to be clear which parts of the semantics relate to "the ABI
for this glibc as a whole" versus "the ABI for this particular compilation
using this glibc and the particular choice of long double made with the
current compilation options".
--
Joseph S. Myers
joseph@codesourcery.com