This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: How to keep Reviewed-by lines in git commits with gerrit.


Jonathan Nieder wrote:

> That means you could do one of the following things:
>
>  1. Treat the gerrit-hosted repository as "source of truth", push all
>     changes through there, and use the replication plugin to mirror to
>     sourceware.org.
>
>     1a. Install a pre-receive hook at sourceware.org to remind people
>         to push to Gerrit instead.
>
>     1b. Even better would be a hook at sourceware.org that forwards
>         the push to Gerrit transparently.  Alas, Git's update hook
>         doesn't provide a way to respond with "I performed the update
>         on my own; please report success and skip performing the ref
>         update", so this would require improving that part of Git's
>         hook interface.
>
>  2. Treat the sourceware.org repository as "source of truth" and use
>     Gerrit for reviews only until you've installed Gerrit there (as
>     you're doing now)
>
>  3. Try to do something fancy with two-way sync.

Nassar (cc-ed) suggests two more options:

   4. Use NFS to share the repository between sourceware.org and
      gnutoolchain-gerrit.osci.io

   5. Redirect Git traffic from sourceware.org to
      gnutoolchain-gerrit.osci.io (using an HTTP 302 in apache config
      for https traffic, netcat for git://, ...)

If it's straightforward to set up NFS in this environment, then (4) is
a good option.

Option (5) might be fussy for people pushing over ssh.  (1a) seems
like a simpler approach in that direction.

Jonathan

> At first glance, either (1a) or (2) looks sensible to me.  I'm happy
> to help in any way I can (or get one of the more experienced Gerrit
> admins here involved ;-)).


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]