This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] test-container: Install with $(sorted-subdirs) [BZ #24794]
- From: Szabolcs Nagy <Szabolcs dot Nagy at arm dot com>
- To: Tulio Magno Quites Machado Filho <tuliom at linux dot ibm dot com>, Stefan Liebler <stli at linux dot ibm dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Cc: nd <nd at arm dot com>
- Date: Thu, 25 Jul 2019 12:46:22 +0000
- Subject: Re: [PATCH] test-container: Install with $(sorted-subdirs) [BZ #24794]
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=arm.com;dmarc=pass action=none header.from=arm.com;dkim=pass header.d=arm.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k//DkwAbDVaai5CEyJiUJMlc/rVlN+WZZBbQ5bVHgHo=; b=nJsLWKe5gBEzuElPuJaHnb12kduSiy+kxb3B4ftac8aYwg73+Z2tEajV/a8iENRcgqRvLJEFbfNblaXP6+53eEyfPzmpuUUd0kkRgxLyCdM+Ytw5NmXff6DPqzqn8PW+8Eb1H2IcxfxPVQbNkLKTGjKb7P9lgUBQZgrOfN3d2UixVOyeaGwQqwLZFQOUS8mmLBTWlF2PJGgbaBsBZUs0QQSbP6f0HOiz8z5i74QihnJ1ayWvNPT+/wG4Qq9VFj8pDHBCVVcDf+qNYUjyuOt8iJJL83pckhsDSz2Un31JjlgM26H9aB9yk6v8w7+JNlgDCUgRYfichzZxW40lQzGywA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dRiQMFwAyq2oa/gispommrV/UqGEsBLzI5hkaXr3hF3lZJ6vcCK8WI3oCLCrnUPyR64YHKaJef0qah4XMWMJdBR/o/ugGD6gAFNn22BgnLLqrrWceDCkeQoIlEtDDEn1Vm82g75G4WS+YNM9RUd6VTWPK0dDLn7Pz++qqQ2Vie69Zb5TZvMgup0pGZEr1oN0kOoUchGuU8PyQ+rfJOoEK34E0TM8swhucu7/jNE/OjQdhvts/m5rdiYWVgo3VReaPSnxPQvvtbWyuQrIKo5PjsTAgIYzyNpQZKlVO0LylWvwUBwhb06nXRjt9pO7zMPMhtUO026JOQN6jcujrJq/UQ==
- Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs dot Nagy at arm dot com;
- References: <87k1c7zbw2.fsf@linux.ibm.com> <20190725000323.15612-1-tuliom@linux.ibm.com>
On 25/07/2019 01:03, Tulio Magno Quites Machado Filho wrote:
> Commit 35e038c1d2ccb3a75395662f9c4f28d85a61444f started to use an
> incomplete list of subdirs based on $(all-subdirs) causing
> testroot.pristine to miss files from nss.
>
> Tested if the list of files in testroot.pristine remains the same.
fwiw with this patch aarch64 buildbot would go back to green.
>
> 2019-07-24 Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
>
> [BZ #24794]
> * Makeconfig (all-subdirs): Improved source comments.
> * Makefile (testroot.pristine/install.stamp): Pass
> subdirs='$(sorted-subdirs)' to make install.
> ---
> Makeconfig | 6 +++---
> Makefile | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Makeconfig b/Makeconfig
> index 0e386fbc19..fd36c58c04 100644
> --- a/Makeconfig
> +++ b/Makeconfig
> @@ -1267,9 +1267,9 @@ else
> libsupport = $(common-objpfx)support/libsupport.a
> endif
>
> -# These are the subdirectories containing the library source. The order
> -# is more or less arbitrary. The sorting step will take care of the
> -# dependencies.
> +# This is a partial list of subdirectories containing the library source.
> +# The order is more or less arbitrary. The sorting step will take care of the
> +# dependencies and generate sorted-subdirs dynamically.
> all-subdirs = csu assert ctype locale intl catgets math setjmp signal \
> stdlib stdio-common libio malloc string wcsmbs time dirent \
> grp pwd posix io termios resource misc socket sysvipc gmon \
> diff --git a/Makefile b/Makefile
> index 9fbf705200..ac1125853b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -402,7 +402,7 @@ ifeq ($(run-built-tests),yes)
> done
> endif
> $(MAKE) install DESTDIR=$(objpfx)testroot.pristine \
> - subdirs='$(all-subdirs)'
> + subdirs='$(sorted-subdirs)'
> touch $(objpfx)testroot.pristine/install.stamp
>
> tests-special-notdir = $(patsubst $(objpfx)%, %, $(tests-special))
>