This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] test-in-container: Install locales into the test container
- From: DJ Delorie <dj at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 09 Jul 2019 14:07:01 -0400
- Subject: Re: [PATCH] test-in-container: Install locales into the test container
Florian Weimer <fweimer@redhat.com> writes:
> The testing time impact of this change is significant: It increases
> total test time from ~13 to ~15 minutes for me. However, I do not
> see any other way to run locale-dependent tests in a container.
This is also the only way to auto-test "make install-locales" too :-)
> $(MAKE) install DESTDIR=$(objpfx)testroot.pristine
> + $(MAKE) localedata/install-locales DESTDIR=$(objpfx)testroot.pristine
> touch $(objpfx)testroot.pristine/install.stamp
This matches what's documented in INSTALL so LGTM.
Reviewed-by: DJ Delorie <dj@redhat.com>