This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC 1/1] testcase fail while using cross-test-ssh wrapper
- From: Florian Weimer <fweimer at redhat dot com>
- To: Mao Han <han_mao at c-sky dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 09 Jul 2019 13:59:15 +0200
- Subject: Re: [RFC 1/1] testcase fail while using cross-test-ssh wrapper
- References: <6067f3ff4ac4b7e991405f216e928e62f4780c8b.1561620739.git.han_mao@c-sky.com> <87d0iku3rq.fsf@oldenburg2.str.redhat.com> <20190709013036.GA7671@vmh-VirtualBox> <87k1crjyxf.fsf@oldenburg2.str.redhat.com> <20190709105020.GA21283@vmh-VirtualBox>
* Mao Han:
> On Tue, Jul 09, 2019 at 12:16:12PM +0200, Florian Weimer wrote:
>> * Mao Han:
>>
>> > The test-wrapper is passed twice and no run_program_env is passed. I
>> > don't know whether the test-wrapper script is unnecessary(last patch)
>> > or the argument passed by Makefile is wrong:
>> >
>> > diff --git a/locale/Makefile b/locale/Makefile
>> > index 0ad99ec..d78cf9b 100644
>> > --- a/locale/Makefile
>> > +++ b/locale/Makefile
>> > @@ -113,5 +113,5 @@ lib := locale-programs
>> > include $(patsubst %,$(..)libof-iterator.mk,$(cpp-srcs-left))
>> >
>> > $(objpfx)tst-locale-locpath.out : tst-locale-locpath.sh $(objpfx)locale
>> > - $(SHELL) $< '$(common-objpfx)' '$(test-wrapper)' '$(test-wrapper-env)' > $@; \
>> > + $(SHELL) $< '$(common-objpfx)' '$(test-wrapper-env)' '$(run-program-env)' > $@; \
>> > $(evaluate-test)
>>
>> Ah. Does this patch work for you? It looks more correct to me, but I
>> have no way of testing it.
>>
>> Thanks,
>> Florian
>
> Yes, I've tested this patch on C-SKY QEMU, it works fine.
Great. Please push this change along with an appropriate ChangeLog
entry.
Thanks,
Florian