This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/3] [ELF] Allow the machine to override stack permissions via USE_DL_EXEC_STACK_OVERRIDE.
- From: Florian Weimer <fweimer at redhat dot com>
- To: Dragan Mladjenovic <dmladjenovic at wavecomp dot com>
- Cc: "libc-alpha\@sourceware.org" <libc-alpha at sourceware dot org>, Joseph Myers <joseph at codesourcery dot com>, Carlos O'Donell <carlos at redhat dot com>, "Maciej W. Rozycki" <macro at linux-mips dot org>, Faraz Shahbazker <fshahbazker at wavecomp dot com>
- Date: Mon, 08 Jul 2019 13:50:14 +0200
- Subject: Re: [PATCH 1/3] [ELF] Allow the machine to override stack permissions via USE_DL_EXEC_STACK_OVERRIDE.
- References: <1561672142-5907-1-git-send-email-dmladjenovic@wavecomp.com> <1561672142-5907-2-git-send-email-dmladjenovic@wavecomp.com>
* Dragan Mladjenovic:
> +#ifdef USE_DL_EXEC_STACK_OVERRIDE
> + /* Program requests a non-executable stack, but architecture does
> + not support it. */
> + if (__glibc_unlikely (_dl_exec_stack_override (&stack_flags) != 0))
> + {
> + errstring = N_("cannot override stack memory protections");
> + goto call_lose_errno;
> + }
> +#endif
Is the comment really correct? I think the proposed MIPS implementation
is not architecture-specific, but specific to the kernel version.
Thanks,
Florian