This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] riscv: restore ABI compatibility (bug 24484)
- From: Palmer Dabbelt <palmer at sifive dot com>
- To: schwab at suse dot de
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 04 Jul 2019 05:51:13 -0700 (PDT)
- Subject: Re: [PATCH] riscv: restore ABI compatibility (bug 24484)
On Thu, 04 Jul 2019 01:24:45 PDT (-0700), schwab@suse.de wrote:
The contents of the dynamic section are part of the ABI, thus
DL_RO_DYN_SECTION cannot be changed.
[BZ #24484]
* sysdeps/riscv/ldsodefs.h (DL_RO_DYN_SECTION): Define.
---
sysdeps/riscv/ldsodefs.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/sysdeps/riscv/ldsodefs.h b/sysdeps/riscv/ldsodefs.h
index 5ec607e867..d7531b707a 100644
--- a/sysdeps/riscv/ldsodefs.h
+++ b/sysdeps/riscv/ldsodefs.h
@@ -38,6 +38,11 @@ struct La_riscv_retval;
struct La_riscv_retval *, \
const char *);
+/* Although the RISC-V ABI does not specify that the dynamic section has
+ to be read-only, it needs to be kept for ABI compatibility. */
+
+#define DL_RO_DYN_SECTION 1
+
#include_next <ldsodefs.h>
#endif
Sorry, I thought I'd committed this already. You're welcome to commit, my
email is still a mess.
Thanks for picking this up!