This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] powerpc: Cleanup: use actual power8 assembly mnemonics
- From: "Gabriel F. T. Gomes" <gabriel at inconstante dot eti dot br>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: <libc-alpha at sourceware dot org>
- Date: Tue, 2 Jul 2019 11:27:08 -0300
- Subject: Re: [PATCH] powerpc: Cleanup: use actual power8 assembly mnemonics
- References: <20190627184417.4118-1-raoni@linux.ibm.com> <20190628164907.hhmkcd64sqwjj4em@tereshkova> <96c22152-56ee-07c3-2a07-396ceb114ee8@linaro.org>
On Mon, Jul 01 2019, Adhemerval Zanella wrote:
>
> I still think it is better to add an assembler check similar to the
> compiler one on sysdeps/powerpc/powerpc64/le/configure.ac for the required
> instructions.
Although the idea of such a check sounds good to me, the check would be
for xssqrtqp, an instruction that has *not* been added by this commit,
but by an old commit (f819dbea0a58). So I think the addition of the
check belongs in a different patch, because this patch works correctly
with the current minimum binutils version, i.e. binutils-2.25.
Does that sound good to you?
Maybe I'm nitpicking (sorry if I am, it's not my intention) but I think
that these problems are semantically independent and should be in
different commits.