This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[RFC 1/1] testcase fail while using cross-test-ssh wrapper
- From: Mao Han <han_mao at c-sky dot com>
- To: libc-alpha at sourceware dot org
- Cc: Mao Han <han_mao at c-sky dot com>, Florian Weimer <fweimer at redhat dot com>, David Newall <glibc at davidnewall dot com>, Vincent Chen <vincentc at andestech dot com>
- Date: Thu, 27 Jun 2019 15:33:48 +0800
- Subject: [RFC 1/1] testcase fail while using cross-test-ssh wrapper
I did a regression test yesterday, and found tst-locale-locpath.sh and
tst-rtld-preload.sh failed due to some script problem. The ssh wrapper
is invoked twice on these testcase, seems some of the arguments are
not pass correctly for cross test.
tst-locale-locpath.sh test cmd:
/home/vmh/workspace/buildroot2/buildroot/output/build/glibc-02d8b5ab1c89bcef2627d2b621bfb35b573852c2/scripts/cross-test-ssh.sh --timeoutfactor 6000 10.0.2.17 /home/vmh/workspace/buildroot2/buildroot/output/build/glibc-02d8b5ab1c89bcef2627d2b621bfb35b573852c2/scripts/cross-test-ssh.sh --timeoutfactor 6000 10.0.2.17 env LC_ALL=invalid-locale LOCPATH=does-not-exist /home/vmh/workspace/buildroot2/buildroot/output/build/glibc-02d8b5ab1c89bcef2627d2b621bfb35b573852c2/build/elf/ld.so --library-path /home/vmh/workspace/buildroot2/buildroot/output/build/glibc-02d8b5ab1c89bcef2627d2b621bfb35b573852c2/build/ /home/vmh/workspace/buildroot2/buildroot/output/build/glibc-02d8b5ab1c89bcef2627d2b621bfb35b573852c2/build/locale/locale
Cc: Florian Weimer <fweimer@redhat.com>
Cc: David Newall <glibc@davidnewall.com>
Cc: Vincent Chen<vincentc@andestech.com>
---
elf/tst-rtld-preload.sh | 2 +-
locale/tst-locale-locpath.sh | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/elf/tst-rtld-preload.sh b/elf/tst-rtld-preload.sh
index f0c0ca1..0fe9e4f 100755
--- a/elf/tst-rtld-preload.sh
+++ b/elf/tst-rtld-preload.sh
@@ -31,7 +31,7 @@ echo "# [${test_wrapper}] [$rtld] [--library-path] [$library_path]" \
"[--preload] [$preload] [$test_program]"
${test_wrapper_env} \
${run_program_env} \
-${test_wrapper} $rtld --library-path "$library_path" \
+$rtld --library-path "$library_path" \
--preload "$preload" $test_program 2>&1 && rc=0 || rc=$?
echo "# exit status $rc"
diff --git a/locale/tst-locale-locpath.sh b/locale/tst-locale-locpath.sh
index b83de90..1281e9c 100644
--- a/locale/tst-locale-locpath.sh
+++ b/locale/tst-locale-locpath.sh
@@ -20,8 +20,8 @@
set -ex
common_objpfx=$1
-test_wrapper_env=$2
-run_program_env=$3
+test_wrapper_env=$3
+run_program_env=
LIBPATH="$common_objpfx"
--
2.7.4