This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Remove obsolete, never-implemented XSI STREAMS declarations


On Tue, Feb 26, 2019 at 9:43 AM Florian Weimer <fweimer@redhat.com> wrote:
> The stub implementations are turned into compat symbols.
>
> Linux actually has two reserved system call numbers (for getpmsg
> and putpmsg), but these system calls have never been implemented,
> and there are no plans to implement them, so this patch replaces
> the wrappers with the generic stubs.
>
> According to <https://bugzilla.redhat.com/show_bug.cgi?id=436349>,
> the presence of the XSI STREAMS declarations is a minor portability
> hazard because they are not actually implemented.

I think it is reasonable to remove these never-implemented and
obsolete-in-POSIX functions.  I don't think I can unilaterally approve
this patch, though, it needs consensus.

The content of the patch looks good to me.  unistd.h already doesn't
define _XOPEN_STREAMS, and we do not have an xti.h, so the only
additional change I request is: Please search the source tree for
additional references to STREAMS, XTI, stropts.h, xti[types].h, the
types defined by stropts.h, etc. and remove them or replace them with
notes that we do not implement STREAMS, as appropriate.  For instance,
this comment in conform/Makefile should be removed and perhaps
replaced with a note that XTI and STREAMS are not implemented in glibc.

> --- a/conform/Makefile
> +++ b/conform/Makefile
> @@ -55,7 +55,7 @@ conformtest-headers-XPG4 :=
>  # XPG42 includes XTI, but xti.h is outside the scope of these tests.

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]