This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Improve bench-strstr


Hi Adhemerval,

> The twoway_strstr is essentially the generic_strstr, I am failing to 
> see the point of replicate it on bench-strstr.c

Well this goes back to the discussion about providing a meaningful baseline
when running the string benchmarks. I'm sure you've noticed my new proposed
strstr [1] and memmem [2] implementations which beat the existing Two-way
by a huge factor. So it's very useful to compare the new generic strstr with the
Two-way implementation as it was. If at some point we replace Two-way
altogether then it would make no sense to keep it in the benchmarks.

[1] https://sourceware.org/ml/libc-alpha/2019-02/msg00021.html
[2] https://sourceware.org/ml/libc-alpha/2019-02/msg00020.html

Cheers,
Wilco

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]