This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PPC64: First in the series of patches implementing POWER8 vector math.


‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Friday, February 15, 2019 9:07 PM, Joseph Myers <joseph@codesourcery.com> wrote:

> On Fri, 15 Feb 2019, GT wrote:
>
> > > > +#if defined _ARCH_PPC64 && defined FAST_MATH
> > >
> > > Is _ARCH_PPC64 correct here - what's the status of support (in the GNU
> > > toolchain, Linux kernel, etc.) for -mpowerpc64 with the 32-bit ABI (which
> > > also defines _ARCH_PPC64)?
> >
> > To address the support issues raised, a solution would be to have
> > 'configure' verify that the compiler generates a valid executable. Then
> > _ARCH_PPC64 would be replaced here by a macro determined at
> > configuration time.
>
> Since installed headers need to work for all multilibs that might share a
> compiler and a set of headers, a configure-time test isn't suitable here.
> I think __powerpc64__ is the correct thing to test as an ABI conditional
> (as opposed to an instruction set conditional) - it's what
> sysdeps/unix/sysv/linux/powerpc/bits/wordsize.h uses.
>

Going by Table 5.1 of the 64-bit ELFV2 ABI, __powerpc64__does appear to be the right macro to test for. I will make that change.

===========
Bert Tenjy.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]