This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Fix fall-through warnings in sunrpc/xdr.c
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Thu, 14 Feb 2019 19:58:24 +0100
- Subject: Re: Fix fall-through warnings in sunrpc/xdr.c
- References: <alpine.DEB.2.21.1902141839200.28311@digraph.polyomino.org.uk>
* Joseph Myers:
> diff --git a/sunrpc/xdr.c b/sunrpc/xdr.c
> index 8b0b91995b..b5fb7455e2 100644
> --- a/sunrpc/xdr.c
> +++ b/sunrpc/xdr.c
> @@ -113,6 +113,7 @@ xdr_int (XDR *xdrs, int *ip)
> return FALSE;
> }
> *ip = (int) l;
> + /* Fall through. */
> case XDR_FREE:
> return TRUE;
I would duplicate the return statement for those cases. But no strong
preference. Patch looks okay as-is.