This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PSA: Formalizing the glibc<->gdb probe-based interface.
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, gdb at sourceware dot org
- Date: Wed, 13 Feb 2019 13:47:31 -0500
- Subject: Re: PSA: Formalizing the glibc<->gdb probe-based interface.
- References: <f73d8f0d-32ac-487d-8f90-fdac7b1be8e8@redhat.com> <87k1i3628v.fsf@tromey.com>
On 2/13/19 12:13 PM, Tom Tromey wrote:
>>>>>> "Carlos" == Carlos O'Donell <carlos@redhat.com> writes:
>
> Carlos> We document *other* probes in manual/probes.texi, but we should
> Carlos> add a section for stable guaranteed probes, and discuss a way
> Carlos> to deprecate the probes should we ever need to do that.
>
> Because probes are introspectable, it's actually better to remove them
> than to change their semantics -- the tools can adapt more easily to
> this. Of course it's good to have a transition period, or at least some
> sort of warning.
>
> As I recall we had some thoughts about ABI compatibility when adding the
> probes; namely that it is ok to add arguments to the end, but not ok to
> remove arguments or to change the meaning of existing arguments.
Agreed.
In general I think the probe name should always change if:
* semantics change.
* # of arguments change.
Then you'll always be safe.
If you can't keep implementing the probe it is safest to remove it.
Talk to the users of the probe first and reach consensus :-)
--
Cheers,
Carlos.