This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Zach, It turned out that memmove tests do OK regarding overlapping memory. This is just not obvious from the outside. So, I might change the interface a bit so that it would be clear that only one buffer is actually used or just add a couple of comments pointing out that two buffers here are just for the sake of uniformity. Considering the above is not going to be such big a change can someone just push a change like this on my behalf? -- Thanks, Anton On 08/2/2019 19:41, Zack Weinberg wrote:
On Fri, Feb 8, 2019 at 10:51 AM Anton Youdkevitch <anton.youdkevitch@bell-sw.com> wrote:The current testing framework is using two buffers for all sorts of string benchmarks. Considering how the buffers get allocated (using mmap with the first argument set to 0) they can never overlap. So, the memmove benchtest actually tests memcpy (with a little additional startup) instead of memmove. I would like to adapt memmove benchset to cover the case of overlapping memory regions as well.Yes, that would be a welcome improvement. It's probably going to be big enough that you will need to file contributor paperwork with the FSF: please read and follow the instructions at https://git.savannah.gnu.org/cgit/gnulib.git/plain/doc/Copyright/request-assign.future zw
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |