This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] nptl: Fix invalid Systemtap probe in pthread_join [BZ #24211]


* Andreas Schwab:

> On Feb 11 2019, Florian Weimer <fweimer@redhat.com> wrote:
>
>> After commit f1ac7455831546e5dca0ed98fe8af2686fae7ce6 ("arm: Use "nr"
>> constraint for Systemtap probes [BZ #24164]"), we load pd->result into
>> a register in the probe below:
>>
>>       /* Free the TCB.  */
>>       __free_tcb (pd);
>>     }
>>   else
>>     pd->joinid = NULL;
>>
>>   LIBC_PROBE (pthread_join_ret, 3, threadid, result, result);
>
> That's not the original nor the new line.

Thanks, clearly I was too tired yesterday.

Do you think this patch is okay, or should I duplicate the probe?  But
even then, I won't be able to avoid the pd_return variable because
thread_return can be NULL, so a separate place for the return value is
needed.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]