This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] nptl: Fix invalid Systemtap probe in pthread_join [BZ #24211]
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 11 Feb 2019 22:11:35 +0100
- Subject: Re: [PATCH] nptl: Fix invalid Systemtap probe in pthread_join [BZ #24211]
- References: <87k1i6cah6.fsf@oldenburg2.str.redhat.com>
On Feb 11 2019, Florian Weimer <fweimer@redhat.com> wrote:
> diff --git a/nptl/pthread_join_common.c b/nptl/pthread_join_common.c
> index ecb78ffba5..45deba6a74 100644
> --- a/nptl/pthread_join_common.c
> +++ b/nptl/pthread_join_common.c
> @@ -101,7 +101,7 @@ __pthread_timedjoin_ex (pthread_t threadid, void **thread_return,
> else
> pd->joinid = NULL;
>
> - LIBC_PROBE (pthread_join_ret, 3, threadid, result, pd->result);
> + LIBC_PROBE (pthread_join_ret, 3, threadid, result, result);
result and pd->result are not the same thing.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."