This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Linux: Add gettid system call wrapper [BZ #6399]


On 2/8/19 9:55 AM, Florian Weimer wrote:
> * Florian Weimer:
> 
>> * Adhemerval Zanella:
>>
>>> On 02/02/2019 12:18, Florian Weimer wrote:
>>>> * Carlos O'Donell:
>>>>
>>>>> OK for master if you fix the copyright years to 2019.
>>>>
>>>> Thanks, I've made this change locally.
>>>>
>>>> I will push this some time next week, unless there are objections.
>>>>
>>>> Florian
>>>>
>>>
>>> Hurd build is failing with:
>>>
>>> In file included from ../include/unistd.h:2,
>>>                  from mach_init.c:20:
>>> ../posix/unistd.h:1170:10: fatal error: bits/unistd_ext.h: No such file or directory
>>>  #include <bits/unistd_ext.h>
>>>
>>> when building mach_init.c. It seems it adds sysdeps/posix in sysdeps
>>> search, but not posix itself:
>>
>> It's a missing wrapper header under include.  I will fix it.
> 
> This should be the fix:
> 
> posix: Fix missing wrapper header for <bits/unistd_ext.h>
> 
> 2019-02-08  Florian Weimer  <fweimer@redhat.com>
> 
> 	* include/bits/unistd_ext.h: New file.
> 
> diff --git a/include/bits/unistd_ext.h b/include/bits/unistd_ext.h
> new file mode 100644
> index 0000000000..24e8d09ba8
> --- /dev/null
> +++ b/include/bits/unistd_ext.h
> @@ -0,0 +1 @@
> +#include <posix/bits/unistd_ext.h>
 
My bmg of i686-gnu passes with this patch.

OK for master.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

-- 
Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]