This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [2.25 / 2.26 / 2.27 / 2.28 / 2.29 COMMITTED] Add compiler barriers around modifications of the robust mutex list for pthread_mutex_trylock. [BZ #24180]

From: Carlos O'Donell <carlos at redhat dot com>
To: Stefan Liebler <stli at linux dot ibm dot com>, GNU C Library <libc-alpha at sourceware dot org>, libc-stable at sourceware dot org
Cc: Thomas Gleixner <tglx at linutronix dot de>, Sebastian Sewior <bigeasy at linutronix dot de>, Heiko Carstens <heiko dot carstens at de dot ibm dot com>, Torvald Riegel <triegel at redhat dot com>, Florian Weimer <fweimer at redhat dot com>
Date: Thu, 7 Feb 2019 15:32:04 -0500
Subject: Re: [2.25 / 2.26 / 2.27 / 2.28 / 2.29 COMMITTED] Add compiler barriers around modifications of the robust mutex list for pthread_mutex_trylock. [BZ #24180]
References: <fcc30533-41b1-a159-7019-290d2c489242@linux.ibm.com> <60ff0bf2-38f9-92b4-7582-8b65c2acfa0e@redhat.com> <c60e8de1-704a-9ff1-6ec9-474e47cc4686@linux.ibm.com> <466ae362-4d20-e911-6b20-f6c2be072c6d@redhat.com> <e480d714-75de-0861-f99f-8a7980e8a508@linux.ibm.com>

On 2/7/19 10:05 AM, Stefan Liebler wrote:
> On 02/06/2019 04:59 PM, Carlos O'Donell wrote:
>> On 2/6/19 6:25 AM, Stefan Liebler wrote:
>>> Hi Carlos,
>>> I've updated the patch with three additional comments and I've mentioned the filed bug.
>>> Please review it once again before I commit it to master and cherry pick it to the release branches.
>>
>> Thank you! Reviewed.
> Committed to master (2.29.9000):
> "Add compiler barriers around modifications of the robust mutex list for pthread_mutex_trylock. [BZ #24180]"
> (https://sourceware.org/git/?p=glibc.git;a=commit;h=823624bdc47f1f80109c9c52dee7939b9386d708)
> 
> and backported it to glibc 2.25 ... 2.29 release branches.

Thank you! Now if only we could fix the final robust mutex
design flaw[1] ;-)

-- 
Cheers,
Carlos.

[1] https://sourceware.org/bugzilla/show_bug.cgi?id=14485

References:
- [PATCH] Add compiler barriers around modifications of the robust mutex list for pthread_mutex_trylock.
  - From: Stefan Liebler
- Re: [PATCH] Add compiler barriers around modifications of the robust mutex list for pthread_mutex_trylock.
  - From: Carlos O'Donell
- Re: [PATCH] Add compiler barriers around modifications of the robust mutex list for pthread_mutex_trylock.
  - From: Stefan Liebler
- Re: [PATCH] Add compiler barriers around modifications of the robust mutex list for pthread_mutex_trylock.
  - From: Carlos O'Donell
- [2.25 / 2.26 / 2.27 / 2.28 / 2.29 COMMITTED] Add compiler barriers around modifications of the robust mutex list for pthread_mutex_trylock. [BZ #24180]
  - From: Stefan Liebler

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]