This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] support: Implement xdlmopen


On Mon, Feb 04 2019, Florian Weimer wrote:
> 
> 	* support/xdlfcn.h (xdlmopen): Declare.
> 	* support/xdlmopen.c: New file.

Missing an entry for the change in support/Makefile.

> +  /* Clear any errors.  */
> +  dlerror ();

Why is this needed?  If the call to dlmopen failed, dlerror is called
from within the preceding FAIL_EXIT1 statement.  I didn't understand
what other errors should be cleared here.

> +  return dso;
> +}
> +

Probably not important, but `git am' complained about a "new blank line
at EOF".  I suppose it's something wrong with my git configuration.  :(


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]