This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Patch] [Makefile] Exit if provided an incorrect argument
- From: Florian Weimer <fweimer at redhat dot com>
- To: Matthew Malcomson <Matthew dot Malcomson at arm dot com>
- Cc: "libc-alpha\@sourceware.org" <libc-alpha at sourceware dot org>, nd <nd at arm dot com>
- Date: Mon, 04 Feb 2019 13:09:43 +0100
- Subject: Re: [Patch] [Makefile] Exit if provided an incorrect argument
- References: <VI1PR0801MB20145F5DF9B9E836FB02F5BCE0A10@VI1PR0801MB2014.eurprd08.prod.outlook.com> <875zuq6xv9.fsf@oldenburg2.str.redhat.com> <beab92e4-fcc6-5a79-03e2-082131fd3c96@arm.com>
* Matthew Malcomson:
> On 15/01/19 10:03, Florian Weimer wrote:
>> * Matthew Malcomson:
>>
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -148,6 +148,7 @@ while test $$# -gt 0 ; do
>>> ;;
>>> --*)
>>> usage
>>> + exit 1
>>> ;;
>>> *)
>>> break
>> I think you should add the exit to the usage function.
>>
>> Thanks,
>> Florian
>
> Makes sense -- thanks!
> Fixed patch attached.
Thanks, pushed.
Florian