Re: glibc 2.29 - Winter is coming...

[Siddhesh Poyarekar <siddhesh at gotplt dot org>]

On 02/01/19 5:22 PM, Rafal Luzynski wrote:
> I have partially reviewed two patches but I don't know whether they are
> correct or not and I've asked for more help or for freeze exceptions before:
>
> [1] Cyrillic -> ASCII transliteration: I am not sure which locale should
> implement the feature (C? Russian + few more? All locales with few
> exceptions?),
> also I am not sure how to deal with digraphs (if an original letter is
> uppercase then should the output digraph be all uppercase, like "SH",
> or should only the first letter be uppercase, like "Sh"?)  This may
> happen to be the change in locale data only.

I've finally mustered up a bit of courage to read up and give my 
opinions on this, given that nobody else has.  My focus has been on 
breaking the deadlock because ISTM that the review is stuck on seemingly 
mundane issues that can either be trivially fixed up later or may not be 
as serious, such as the choice of implementing in C vs one of the Latin 
locales or the use of all-caps vs init-caps.

However, I am acutely aware that I may not understand the gravity of 
some of the differences and you're free to throw my opinions out the 
window :)

> [2] [3] Default width for "%Ey" which is important due to the Japanese
> era change in 4 months.  Also, this patch fixes handling of formatting
> flags so if that helps it can be split into the patches fixing the width
> issue and fixing the flags issue.

A more detailed explanation of what the Japanese era change entails is 
needed in here, i.e. why is the padding needed and what would the output 
look like if we don't fix it in this release and why that would be a 
problem.

Other than that, this seems like something we can make an exception for, 
assuming that it does not affect translations.  I personally would have 
done 2 different patches, but I know others in the community who would 
have stuck this into a single patch so I don't have too strong an 
opinion about that aspect of this patch.

Siddhesh