This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] riscv: Use __has_include__ to include <asm/syscalls.h> [BZ #24022]
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 31 Dec 2018 19:25:06 +0100
- Subject: Re: [PATCH] riscv: Use __has_include__ to include <asm/syscalls.h> [BZ #24022]
- References: <20181221174840.10933-1-hjl.tools@gmail.com> <87y385egyx.fsf@mid.deneb.enyo.de> <CAMe9rOr276A6=vxixOrNqL9fLNdCRDDpaHdMTsk30L7ihi=JSQ@mail.gmail.com>
* H. J. Lu:
> On Mon, Dec 31, 2018 at 9:36 AM Florian Weimer <fw@deneb.enyo.de> wrote:
>>
>> * H. J. Lu:
>>
>> > +#if __has_include__ (<asm/syscalls.h>)
>>
>> Isn't __has_include (no trailing __) the more canonical name?
>> I think that's what's in C++17.
>
> I think __has_include__ is OK for glibc internal source.
Both are accepted by the compiler. But I want to reduce cognitive
load for the reader, and avoid use unportable constructs when
prefectly portable ones exist.