This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Set behavior of sprintf-like functions with overlapping source and destination

From: Siddhesh Poyarekar <siddhesh at gotplt dot org>
To: Zack Weinberg <zackw at panix dot com>, "Gabriel F. T. Gomes" <gabriel at inconstante dot eti dot br>
Cc: Paul Eggert <eggert at cs dot ucla dot edu>, Jonathan Nieder <jrnieder at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
Date: Sat, 29 Dec 2018 07:07:48 +0530
Subject: Re: [PATCH] Set behavior of sprintf-like functions with overlapping source and destination
References: <20181220215409.8971-1-gabriel@inconstante.eti.br> <fd68b440-14ce-dd14-fd80-20c80e097e20@cs.ucla.edu> <03d805a8-258c-cefa-4c8d-f4f1d577c3d5@gotplt.org> <9e180abb-7527-5759-0850-e23d0bb23f73@cs.ucla.edu> <20181226201950.GD11055@google.com> <b71e3d74-1e94-bdd5-5d01-b2fe2a69c939@cs.ucla.edu> <0ac86b95-7eaa-e490-57e8-5d9f208a10d3@gotplt.org> <CAKCAbMiMdJCrnTkYQfyG8TNNbKvVTE-orpQacLu1tH3z07jc_g@mail.gmail.com> <5466ebd4-b5b5-37e7-b3de-5851f71c3e11@gotplt.org> <20181227134645.vgsg5et4e5hhcw4r@tereshkova> <CAKCAbMiht79zvqVB8vmtFV6qE9UyPS=WSA219qiu8ODRcAez+Q@mail.gmail.com>

On 27/12/18 10:29 PM, Zack Weinberg wrote:

On Thu, Dec 27, 2018 at 8:46 AM Gabriel F. T. Gomes
<gabriel@inconstante.eti.br> wrote:

On Thu, Dec 27, 2018 at 11:15:06AM +0530, Siddhesh Poyarekar wrote:

Thanks, to clarify, is your position that we revert to old behaviour (for
now) for the default case only or for everything, including _FORTIFY_SOURCE?


The _FORTIFY_SOURCE version did not change behaviour...  Even before
Zack's patches, it would overwrite overlapping buffers.  This means that
this patch, as it is today, reverts all behavior to what it used to be.


Yes.  My position right now is that we should merge Gabriel's patch as
is -- including the test case! -- for 2.29, and consider whether we
want to make any further changes after the release.

OK thaks for the clarification. Paul, do you have a strong oppositionto this or is it OK if we take this course for this release?


Siddhesh

References:
- [PATCH] Set behavior of sprintf-like functions with overlapping source and destination
  - From: Gabriel F. T. Gomes
- Re: [PATCH] Set behavior of sprintf-like functions with overlapping source and destination
  - From: Paul Eggert
- Re: [PATCH] Set behavior of sprintf-like functions with overlapping source and destination
  - From: Siddhesh Poyarekar
- Re: [PATCH] Set behavior of sprintf-like functions with overlapping source and destination
  - From: Paul Eggert
- Re: [PATCH] Set behavior of sprintf-like functions with overlapping source and destination
  - From: Jonathan Nieder
- Re: [PATCH] Set behavior of sprintf-like functions with overlapping source and destination
  - From: Paul Eggert
- Re: [PATCH] Set behavior of sprintf-like functions with overlapping source and destination
  - From: Siddhesh Poyarekar
- Re: [PATCH] Set behavior of sprintf-like functions with overlapping source and destination
  - From: Zack Weinberg
- Re: [PATCH] Set behavior of sprintf-like functions with overlapping source and destination
  - From: Siddhesh Poyarekar
- Re: [PATCH] Set behavior of sprintf-like functions with overlapping source and destination
  - From: Gabriel F. T. Gomes
- Re: [PATCH] Set behavior of sprintf-like functions with overlapping source and destination
  - From: Zack Weinberg

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]