This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 4/5] Y2038: add function __ctime64

From: Albert ARIBAUD <albert dot aribaud at 3adev dot fr>
To: Florian Weimer <fweimer at redhat dot com>
Cc: Joseph Myers <joseph at codesourcery dot com>, <libc-alpha at sourceware dot org>
Date: Tue, 18 Dec 2018 20:23:03 +0100
Subject: Re: [PATCH v2 4/5] Y2038: add function __ctime64
References: <20181218140955.7910-1-albert.aribaud@3adev.fr> <20181218140955.7910-5-albert.aribaud@3adev.fr> <alpine.DEB.2.21.1812181731020.2407@digraph.polyomino.org.uk> <87a7l220l4.fsf@oldenburg2.str.redhat.com>

Hi Florian,

On Tue, 18 Dec 2018 18:42:31 +0100, Florian Weimer <fweimer@redhat.com>
wrote :

> * Joseph Myers:
> 
> > On Tue, 18 Dec 2018, Albert ARIBAUD (3ADEV) wrote:
> >  
> >> +libc_hidden_proto(__ctime64);  
> >
> > Missing space before '('.
> >  
> >> +libc_hidden_def(__ctime64);  
> >
> > Likewise.  
> 
> Also superfluous semicolon.

Will be fixed (on __ctime64_r also) before applying, thanks.

> Thanks,
> Florian

Cordialement,
Albert ARIBAUD
3ADEV

References:
- [PATCH v2 0/5] Y2038: process remaining struct tm conv functions
  - From: Albert ARIBAUD (3ADEV)
- [PATCH v2 4/5] Y2038: add function __ctime64
  - From: Albert ARIBAUD (3ADEV)
- Re: [PATCH v2 4/5] Y2038: add function __ctime64
  - From: Joseph Myers
- Re: [PATCH v2 4/5] Y2038: add function __ctime64
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]