This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/5] Y2038: add function __gmtime64
Hi Paul,
On Mon, 17 Dec 2018 14:09:01 -0800, Paul Eggert <eggert@cs.ucla.edu>
wrote :
> On 12/17/18 2:04 PM, Albert ARIBAUD (3ADEV) wrote:
> > +#if __TIMESIZE == 64
> > +# define __gmtime64 gmtime
> > +#endif
>
> Why does this look different from the already-installed patch for
> __localtime64, which has the following before the #endif?
>
> +#else
> +extern struct tm *__localtime64 (const __time64_t *__timer);
> +libc_hidden_proto (__localtime64)
Overlook, fixed in v2.
> > --- a/time/gmtime.c
> > +++ b/time/gmtime.c
> > @@ -25,13 +25,26 @@ __gmtime_r (const time_t *t, struct tm *tp)
> > {
> > return __tz_convert (*t, 0, tp);
> > }
> > +
> > libc_hidden_def (__gmtime_r)
> > weak_alias (__gmtime_r, gmtime_r)
>
> No need for this whitespace change.
Ditto.
Thanks for your feedback!
Cordialement,
Albert ARIBAUD
3ADEV