This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/5] m68k: Fix sigaction kernel definition (BZ #23960)
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 11 Dec 2018 22:26:45 +0100
- Subject: Re: [PATCH 1/5] m68k: Fix sigaction kernel definition (BZ #23960)
- References: <20181211195554.3377-1-adhemerval.zanella@linaro.org>
On Dez 11 2018, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
> diff --git a/sysdeps/unix/sysv/linux/m68k/kernel_sigaction.h b/sysdeps/unix/sysv/linux/m68k/kernel_sigaction.h
> index 54972feb13..eef4bb9b65 100644
> --- a/sysdeps/unix/sysv/linux/m68k/kernel_sigaction.h
> +++ b/sysdeps/unix/sysv/linux/m68k/kernel_sigaction.h
> @@ -1,22 +1,8 @@
> -#ifndef _KERNEL_SIGACTION_H
> -# define _KERNEL_SIGACTION_H
> -
> -#include <signal.h>
> -
> +/* m68k uses the generic Linux UAPI but defines SA_RESTORER. */
> #define SA_RESTORER 0x04000000
> -
> -/* This is the sigaction structure from the Linux 3.2 kernel. */
> -struct kernel_sigaction
> -{
> - __sighandler_t k_sa_handler;
> - sigset_t sa_mask;
> - unsigned long sa_flags;
> - void (*sa_restorer) (void);
> -};
> +#include <sysdeps/unix/sysv/linux/kernel_sigaction.h>
>
> #define SET_SA_RESTORER(kact, act) \
> (kact)->sa_restorer = (act)->sa_restorer
> #define RESET_SA_RESTORER(act, kact) \
> (act)->sa_restorer = (kact)->sa_restorer
> -
> -#endif
There should be no need to read or set sa_restorer. The kernel does not
use it, and it also doesn't define SA_RESTORER.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."