Re: [PATCH 1/2] linux: Consolidate sigaction implementation

[Adhemerval Zanella <adhemerval dot zanella at linaro dot org>]

On 10/12/2018 14:28, Andreas Schwab wrote:
> On Nov 17 2017, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
> 
>>   - All architectures now define and use a kernel_sigaction struct meant
>>     for the syscall, even for the architectures where the user sigaction
>>     has the same layout of the kernel expected one (s390-64 and ia64).
>>     Although it requires more work for these architectures, it simplifies
>>     the generic implementation. Also, sigaction is hardly a hotspot where
>>     micro optimization would play an important role.
>>
>>   - The generic kernel_sigaction definition is now aligned with expected
>>     UAPI one for newer ports, where SA_RESTORER and sa_restorer is not
>>     expected to be defined.  This means adding kernel_sigaction for
>>     current architectures that does define it (m68k, nios2, powerpc, s390,
>>     sh, sparc, and tile) and which rely on previous generic definition.
> 
> There is no need to define kernel_sigaction in more than one file, since
> it is the same (except for the presense of sa_restorer) for all
> architectures.

Indeed currently we have some architectures with duplicated definition 
(alpha, s390, ia64, and hppa), however mips still requires its own
definition (__ARCH_HAS_IRIX_SIGACTION).

I am working on a fix for BZ#23960 along with a cleanup for
kernel_sigaction.