This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Reindent nptl/pthread_rwlock_common.c
On Dez 11 2018, Florian Weimer <fweimer@redhat.com> wrote:
> * Andreas Schwab:
>
>> @@ -338,8 +338,9 @@ __pthread_rwlock_rdlock_full (pthread_rwlock_t *rwlock,
>> expected value for future operations. Acquire MO so we synchronize with
>> prior writers as well as the last reader of the previous read phase (see
>> below). */
>> - r = atomic_fetch_add_acquire (&rwlock->__data.__readers,
>> - (1 << PTHREAD_RWLOCK_READER_SHIFT)) + (1 << PTHREAD_RWLOCK_READER_SHIFT);
>> + r = (atomic_fetch_add_acquire (&rwlock->__data.__readers,
>> + (1 << PTHREAD_RWLOCK_READER_SHIFT))
>> + + (1 << PTHREAD_RWLOCK_READER_SHIFT));
>
> Aren't some of these parentheses you are removing recommended for
> getting correct indentation from Emacs?
Which parens do I remove?
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."