This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: RFC: Add PT_GNU_PROPERTY to cover .note.gnu.property section
- From: Florian Weimer <fweimer at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Cary Coutant <ccoutant at gmail dot com>, Binutils <binutils at sourceware dot org>, GNU C Library <libc-alpha at sourceware dot org>, gnu-gabi at sourceware dot org, x86-64-abi <x86-64-abi at googlegroups dot com>
- Date: Tue, 11 Dec 2018 11:27:27 +0100
- Subject: Re: RFC: Add PT_GNU_PROPERTY to cover .note.gnu.property section
- References: <CAMe9rOqk-s5LHb0dAOZJ=GdLeUgqY-sdx3GLBLeBsnM=kU1dZQ@mail.gmail.com> <87ftvoouda.fsf@oldenburg.str.redhat.com> <CAMe9rOrk8DoAJ8Qusy3ZrzSx-ZwERiaPvbwARKnzW7QzELWRGQ@mail.gmail.com> <CAJimCsHRsi48qpGVu2V8KTf+_u247Ojf5EnSs7wUwn4_ogx4AA@mail.gmail.com> <CAMe9rOp9aqysmkTx2e9QzAqDpM=a+xnVXr_SQ0c8A4auhinVsw@mail.gmail.com> <87k1kyhbki.fsf@oldenburg.str.redhat.com> <CAMe9rOq6AgykBthApfHsFgbTHM9LjocDP-DNjB=Dht5uOagT7g@mail.gmail.com> <CAJimCsEDCNWBZsMEMeco0Vkj03iXML08KpLvAxC3DtyzXq8abA@mail.gmail.com> <CAMe9rOqHfqfbu_V1bPgykyN352btS8eZpRm-HAwJDfTf_Fiy-Q@mail.gmail.com> <CAMe9rOp7C_HS4cg-GcHH6NhT5oP-BxzE9emc6+Szx_-mAvxONw@mail.gmail.com> <CAMe9rOq4viqCYVXuVbyzTY0R0XVxzjc_tis9Uxw9OmgZRYcOjA@mail.gmail.com> <CAMe9rOp724pNQhndd8_-bVOS=42=0a4Ajsmgi2LUzA1P2BeWvw@mail.gmail.com>
* H. J. Lu:
> diff --git a/ld/testsuite/ld-elf/pr23900-1b.d b/ld/testsuite/ld-elf/pr23900-1b.d
> new file mode 100644
> index 0000000000..e1555c29f6
> --- /dev/null
> +++ b/ld/testsuite/ld-elf/pr23900-1b.d
> @@ -0,0 +1,14 @@
> +#source: pr23900-1.s
> +#ld:
> +#readelf: -l --wide
> +#target: *-*-linux* *-*-gnu* *-*-nacl*
> +
> +#...
> + GNU_PROPERTY .*
> +#...
> + +[0-9]+ +\.note\.gnu\.property
> +#...
> + +[0-9]+ +\.note\.gnu\.property
> +#...
> + +[0-9]+ +\.note\.gnu\.property
> +#...
Sholdn't there be a test that checks that the segment alignment is as
expected?
What happened to the earlier concerns that the presence of
PT_GNU_PROPERTY will break some existing installations?
I would strongly recommended to try harder to get consensus here. I do
not want to be a in a situation were we revise ABI again two years from
now.
Thanks,
Florian