This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix powf overflow handling in non-nearest rounding mode [BZ #23961]
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Szabolcs Nagy <Szabolcs dot Nagy at arm dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, nd <nd at arm dot com>
- Date: Mon, 10 Dec 2018 22:15:27 +0000
- Subject: Re: [PATCH] Fix powf overflow handling in non-nearest rounding mode [BZ #23961]
- References: <b5887546-4923-8286-9cb8-3bb077acef08@arm.com>
On Mon, 10 Dec 2018, Szabolcs Nagy wrote:
> 2018-12-10 Szabolcs Nagy <szabolcs.nagy@arm.com>
>
> [BZ #23961]
> * math/auto-libm-test-in: Add new test case.
> * math/auto-libm-test-out-pow: Regenerated.
> * sysdeps/ieee754/flt-32/e_powf.c (__powf): Fix overflow check.
OK.
(It's possible some architecture with its own powf implementation could
need to XFAIL the new tests if that architecture doesn't get overflow
exactly right for those cases: the test infrastructure doesn't currently
support marking a test as very close to the overflow threshold and then
allowing appropriately for computed results on the other side of that
threshold only being slightly inaccurate, so OK, as long as they handle
errno / exceptions consistently with the returned value.)
--
Joseph S. Myers
joseph@codesourcery.com