This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] support: Implement <support/descriptors.h> to track file descriptors
- From: Florian Weimer <fweimer at redhat dot com>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 06 Dec 2018 15:40:53 +0100
- Subject: Re: [PATCH] support: Implement <support/descriptors.h> to track file descriptors
- References: <875zwifn4p.fsf@oldenburg.str.redhat.com> <88f3b9d5-f005-85d2-4e0e-936b299c164f@redhat.com> <8736rjyy3i.fsf@oldenburg.str.redhat.com> <36b1bfca-df5f-eb84-2c52-d4605f3c5a20@redhat.com> <87d0qlo5eq.fsf@oldenburg.str.redhat.com> <ddbba683-f703-f204-b1cd-a3fc470a0fc7@redhat.com>
* Carlos O'Donell:
> On 12/1/18 6:25 AM, Florian Weimer wrote:
>> * Carlos O'Donell:
>>
>>> On 11/29/18 11:43 PM, Florian Weimer wrote:
>>>> I could try to count more precisely how many bytes are actually needed,
>>>> but that seemed like a waste of mental resources. Should I use
>>>> xasprintf instead, to make clear that there is no truncation?
>>>
>>> Yes, I think xasprintf solves all the problems.
>>
>> Like this?
>>
>> I also enhanced the test to test more conditions in the list merging
>> code.
>>
>> Thanks,
>> Florian
>
> OK for master. Thank you!
I had to rename the local struct descriptor to struct procfs_descriptor,
due to a conflict with a mach header. Pushed with that change.
Thanks,
Florian