This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix test-as-const-jmp_buf-ssp.c generation on gnu-i386
- From: Samuel Thibault <samuel dot thibault at gnu dot org>
- To: libc-alpha at sourceware dot org
- Cc: Joseph Myers <joseph at codesourcery dot com>
- Date: Sat, 1 Dec 2018 23:44:19 +0000
- Subject: Re: [PATCH] Fix test-as-const-jmp_buf-ssp.c generation on gnu-i386
- References: <20181201231247.p7z3veulcqxfd2o2@function>
Samuel Thibault, le dim. 02 déc. 2018 00:12:47 +0100, a ecrit:
> hurd's jmp_buf-ssp.sym does not define any symbol.
> scripts/gen-as-const.py currently was emitting an empty line in that
> case, and the gawk invocation was prepending "asconst_" to it, ending up
> with:
>
> .../build/glibc/setjmp/test-as-const-jmp_buf-ssp.c:1:2: error: expected « = », « , », « ; », « asm » or « __attribute__ » at end of input
> 1 | asconst_
> | ^~~~~~~~
That said, it's not enough, gen_test() does not emit a main() function,
and thus the test build fails with missing reference to main(). Is there
a strong reason for making the emission of code lazy with the started
boolean?
Samuel