This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 02/56] S390: Use hwcap instead of dl_hwcap in ifunc-resolvers.

From: Florian Weimer <fweimer at redhat dot com>
To: Stefan Liebler <stli at linux dot ibm dot com>
Cc: libc-alpha at sourceware dot org
Date: Fri, 30 Nov 2018 18:36:36 +0100
Subject: Re: [PATCH 02/56] S390: Use hwcap instead of dl_hwcap in ifunc-resolvers.
References: <1543593514-10251-1-git-send-email-stli@linux.ibm.com> <1543593514-10251-3-git-send-email-stli@linux.ibm.com>

* Stefan Liebler:

> +  if (__glibc_likely((hwcap & HWCAP_S390_STFLE)				\

Missing space before paren.  Since HWCAP_S390_STFLE 4 is four, this
__glibc_likely is actually equivalent to __glibc_unlikely, so perhaps
you should drop it.

Thanks,
Florian

References:
- [PATCH] S390: Refactor ifunc handling
  - From: Stefan Liebler
- [PATCH 02/56] S390: Use hwcap instead of dl_hwcap in ifunc-resolvers.
  - From: Stefan Liebler

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]