This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH v6 00/13]port C-SKY to glibc
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Mao Han <han_mao at c-sky dot com>
- Cc: <libc-alpha at sourceware dot org>, <c-sky_gcc_upstream at c-sky dot com>, <gnu-csky at mentor dot com>, <ren_guo at c-sky dot com>, <yibin_liu at c-sky dot com>
- Date: Thu, 29 Nov 2018 17:16:58 +0000
- Subject: Re: [PATCH v6 00/13]port C-SKY to glibc
- References: <email@example.com>
On Thu, 29 Nov 2018, Mao Han wrote:
> It seems quite hard to valuate the effect of remove restriction on
> init-array check in gcc configure. We don't know much about what it will
> affect, and can not help to verify this on other platform.
It's not your responsibility to make sure it works on all other platforms.
You should propose the patch to enable initfini-array for cross
compilation (subject to the existing tests that currently run in the
native case despite being just as valid for cross-compilation), and then
if someone discovers a platform supported by GCC, where that compilation
test passes but initfini-array support does not work correctly, at that
point we can look at the right way to avoid enabling initfini-array
support for that target.
(There are other ways of ensuring GCC uses initfini-array support
unconditionally for a target - look at what's done for Arm EABI, which
also uses initfini-array only. But in the first instance, fixing the
configure test is the natural thing to do to make this work better for all
ELF architectures. In any case, this should be fixed so that GCC gets it
right and no special use of --enable-initfini-array is needed in
Joseph S. Myers