This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] argp: do not call _IO_fwide() if _LIBC is not defined

From: Joseph Myers <joseph at codesourcery dot com>
To: Zack Weinberg <zackw at panix dot com>
Cc: <charles-antoine dot couret at essensium dot com>, GNU C Library <libc-alpha at sourceware dot org>
Date: Wed, 28 Nov 2018 17:10:44 +0000
Subject: Re: [PATCH] argp: do not call _IO_fwide() if _LIBC is not defined
References: <20181128114839.5680-1-charles-antoine.couret@essensium.com> <alpine.DEB.2.21.1811281650070.5954@digraph.polyomino.org.uk> <CAKCAbMieBGDXeze591Ekxk9EhYRM6stzeeHWt25-MFozt=qHzA@mail.gmail.com>

On Wed, 28 Nov 2018, Zack Weinberg wrote:

> I'd also point out that the portable outside-libc version might be
> advised to use fwide() here, the public equivalent of _IO_fwide(),
> instead of just assuming the stream is narrow-oriented.

Yes.  (But that's not a requirement for this patch, which could be applied 
as-is, subject to a glibc testsuite run, if indeed it matches the gnulib 
code.)

-- 
Joseph S. Myers
joseph@codesourcery.com

Follow-Ups:
- Re: [PATCH] argp: do not call _IO_fwide() if _LIBC is not defined
  - From: Couret Charles-Antoine

References:
- [PATCH] argp: do not call _IO_fwide() if _LIBC is not defined
  - From: Charles-Antoine Couret
- Re: [PATCH] argp: do not call _IO_fwide() if _LIBC is not defined
  - From: Joseph Myers
- Re: [PATCH] argp: do not call _IO_fwide() if _LIBC is not defined
  - From: Zack Weinberg

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]