This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
proposal: disable tcache when using malloc_check
- From: DJ Delorie <dj at redhat dot com>
- To: libc-alpha at sourceware dot org
- Date: Tue, 13 Nov 2018 19:00:54 -0500
- Subject: proposal: disable tcache when using malloc_check
This is a fairly trivial change with significant side effects. The
idea is that when one is using malloc_check (via tunables or environ)
correctness and paranoia are favored over performance. Thus, as
tcache bypasses all the malloc_check semantics, it should be disabled
therein so that every malloc/free/etc get the full malloc_check
treatment.
Does anyone have any opinions for or against this idea?
* malloc/hooks.c (__malloc_check_init): Disable tcache.
diff --git a/malloc/hooks.c b/malloc/hooks.c
index ae7305b036..16bca80202 100644
--- a/malloc/hooks.c
+++ b/malloc/hooks.c
@@ -61,6 +61,7 @@ __malloc_check_init (void)
__free_hook = free_check;
__realloc_hook = realloc_check;
__memalign_hook = memalign_check;
+ do_set_tcache_count (0);
}
/* A simple, standard set of debugging hooks. Overhead is `only' one