This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Indentation, tabs, and spaces (was re: [PATCH] support: Implement TEST_COMPARE_STRING)

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Joseph Myers <joseph at codesourcery dot com>, David Newall <glibc at davidnewall dot com>
Cc: Zack Weinberg <zackw at panix dot com>, GNU C Library <libc-alpha at sourceware dot org>
Date: Wed, 7 Nov 2018 17:34:35 -0800
Subject: Re: Indentation, tabs, and spaces (was re: [PATCH] support: Implement TEST_COMPARE_STRING)
References: <CAKCAbMhOr2=peqhfG9rarW15nJT7zA=2AaXPOYGScCBD1aG9qw@mail.gmail.com> <alpine.DEB.2.21.1811071630590.17963@digraph.polyomino.org.uk> <36c88794-16a4-ae96-ae6e-0c383283afa8@davidnewall.com> <alpine.DEB.2.21.1811080034230.32166@digraph.polyomino.org.uk>

Joseph Myers wrote:

*Not*  reformatting makes parts of the code hard to read

I'm with Joseph on this one. Although there are obviously tradeoffs here, weshouldn't unduly contort our code merely because "git diff" is a convenient toolfor comparing versions. Git and diff are our servants, not our masters.

References:
- Indentation, tabs, and spaces (was re: [PATCH] support: Implement TEST_COMPARE_STRING)
  - From: Zack Weinberg
- Re: Indentation, tabs, and spaces (was re: [PATCH] support: Implement TEST_COMPARE_STRING)
  - From: Joseph Myers
- Re: Indentation, tabs, and spaces (was re: [PATCH] support: Implement TEST_COMPARE_STRING)
  - From: David Newall
- Re: Indentation, tabs, and spaces (was re: [PATCH] support: Implement TEST_COMPARE_STRING)
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]