This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Ensure mktime sets errno on error (bug 23789)

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Albert ARIBAUD <albert dot aribaud at 3adev dot fr>
Cc: libc-alpha at sourceware dot org
Date: Fri, 26 Oct 2018 15:45:29 -0700
Subject: Re: [PATCH] Ensure mktime sets errno on error (bug 23789)
References: <20181024193206.22790-1-albert.aribaud@3adev.fr> <544f75df-d977-b4cb-a256-ea289f41262a@cs.ucla.edu> <20181025185733.750d8bdd@athena> <032c79c0-a16e-0d14-6ade-1e720aecd86a@cs.ucla.edu> <20181026181222.6d3faa04@athena> <351571f8-9b1d-7b1f-503b-a99adc697840@cs.ucla.edu> <20181026231827.173c8ccf@athena>

On 10/26/18 2:18 PM, Albert ARIBAUD wrote:

Is it allowed behavior to
alter errno when not returning an error condition?

Ordinarily yes. But it would be better if mktime left errno alone when-1 does not represent an error, so that the caller can easilydistinguish valid -1 return values from erroneous ones.

Follow-Ups:
- Re: [PATCH] Ensure mktime sets errno on error (bug 23789)
  - From: Albert ARIBAUD

References:
- [PATCH] Ensure mktime sets errno on error (bug 23789)
  - From: Albert ARIBAUD (3ADEV)
- Re: [PATCH] Ensure mktime sets errno on error (bug 23789)
  - From: Paul Eggert
- Re: [PATCH] Ensure mktime sets errno on error (bug 23789)
  - From: Albert ARIBAUD
- Re: [PATCH] Ensure mktime sets errno on error (bug 23789)
  - From: Paul Eggert
- Re: [PATCH] Ensure mktime sets errno on error (bug 23789)
  - From: Albert ARIBAUD
- Re: [PATCH] Ensure mktime sets errno on error (bug 23789)
  - From: Paul Eggert
- Re: [PATCH] Ensure mktime sets errno on error (bug 23789)
  - From: Albert ARIBAUD

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]