This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: glibc bug 23789 (was: [PATCH v3] Y2038: make __mktime_internal compatibles with __time64_t)


Bonjour Joseph,

Le Wed, 24 Oct 2018 16:20:50 +0000, Joseph Myers
<joseph@codesourcery.com> a écrit :

> On Wed, 24 Oct 2018, Albert ARIBAUD wrote:
> 
> > And one last question: should I not first commit the test (and with make
> > check on a 32-bit architecture, show that it adds one FAIL) then commit
> > the fix (and show with the same make check that the FAIL disappears)?  
> 
> No, you should verify the FAIL with the fix not present, but the test is 
> best committed at the same time as a fix, to preserve bisectability.

Understood. I have already verified the FAIL once the test is in but
not the fix, using i686-linux-gnu.

Cordialement,
Albert ARIBAUD
3ADEV


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]