This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix the ld flags not be applied to tst-execstack-mod.so
- From: Zong Li <zongbox at gmail dot com>
- To: Zong Li <zong at andestech dot com>
- Cc: joseph at codesourcery dot com, libc-alpha at sourceware dot org
- Date: Tue, 16 Oct 2018 00:59:00 +0800
- Subject: Re: [PATCH] Fix the ld flags not be applied to tst-execstack-mod.so
- References: <1532081682-25895-1-git-send-email-zong@andestech.com>
Zong Li <zong@andestech.com> 於 2018年7月20日 週五 下午6:14寫道：
>
> The Makefile variable name loses the file extension (.so). It causes
> the linker option not applies to the corresponding file that it's
> file name matchs with the variable without LDFLAGS- prefix.
>
> * elf/Makefile (LDFLAGS-tst-execstack-mod): Change variable name by
> adding the file extension (.so).
> ---
> ChangeLog | 5 +++++
> elf/Makefile | 2 +-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/ChangeLog b/ChangeLog
> index b45c83b..f87b32c 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2018-07-20 Zong Li <zong@andestech.com>
> +
> + * elf/Makefile (LDFLAGS-tst-execstack-mod): Change variable name by
> + adding the file extension (.so).
> +
> 2018-07-20 Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> * sysdeps/mach/hurd/i386/tls.h (_hurd_tls_init): Set multiple_threads
> diff --git a/elf/Makefile b/elf/Makefile
> index cd07713..ecc8ea2 100644
> --- a/elf/Makefile
> +++ b/elf/Makefile
> @@ -1004,7 +1004,7 @@ $(objpfx)tst-execstack: $(libdl)
> $(objpfx)tst-execstack.out: $(objpfx)tst-execstack-mod.so
> CPPFLAGS-tst-execstack.c += -DUSE_PTHREADS=0
> LDFLAGS-tst-execstack = -Wl,-z,noexecstack
> -LDFLAGS-tst-execstack-mod = -Wl,-z,execstack
> +LDFLAGS-tst-execstack-mod.so = -Wl,-z,execstack
>
> $(objpfx)tst-execstack-needed: $(objpfx)tst-execstack-mod.so
> LDFLAGS-tst-execstack-needed = -Wl,-z,noexecstack
> --
> 2.7.4
ping
We leave the previous release freeze. I ping again here.